Repository navigation
SNOW-4512105: Replace jsr305 with jspecify for nullability annotations - #1179
Open
sfc-gh-alhuang wants to merge 2 commits into
Open
sfc-gh-alhuang wants to merge 2 commits into
sfc-gh-alhuang wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1179 +/- ##
==========================================
+ Coverage 61.57% 61.60% +0.02%
==========================================
Files 214 214
Lines 14674 14674
Branches 1614 1614
==========================================
+ Hits 9036 9040 +4
+ Misses 4926 4922 -4
Partials 712 712 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sfc-gh-ggeng
approved these changes
Nov 17, 2026
sfc-gh-alhuang
enabled auto-merge (squash)
November 17, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
javax.annotation(jsr305) nullability annotations withorg.jspecify.annotations, so the shaded jar no longer contains jsr305 classes.Why
jsr305 is EOL and Informatica's third-party library policy rejects it. It was being relocated inside the shaded jar (35 classes).
Mechanism
jsr305 reached the shaded jar from two sources: the SDK's direct optional dependency, and a transitive dependency via
google-auth-library-oauth2-http1.29.0, which the direct declaration was hiding.Change
Nullable/Nonnullimports swapped toorg.jspecify.annotationsgoogle-auth-library-oauth2-httpResult
mvn clean package -DskipTestspasses and the shaded jar has 0javax/annotationentries.Compatibility
Testing
javax/annotationentries./tmp/triage-2026-11-13/SNOW-4512105-test*.log) were not fully green. Per the logs: one run of 114 tests had 2 errors and 2 skipped, and a later rerun ofInternalStageTest(11 tests) had 1 error. Every error I inspected there wasInaccessibleObject(JDK module--add-opensforjava.nio.file/java.util.concurrent), which is a local JVM-flag problem, not a failure caused by this change. The first run (many errors) and a fourth log were not clean either and were not analysed further.OAuthBasicTestnot run locally (needs qa1).Links
🤖 Generated with Claude Code