Skip to content

SNOW-4512105: Replace jsr305 with jspecify for nullability annotations - #1179

Open
sfc-gh-alhuang wants to merge 2 commits into
masterfrom
alhuang-snow-4512105-replace-jsr305-with-jspecify
Open

sfc-gh-alhuang wants to merge 2 commits into
masterfrom
alhuang-snow-4512105-replace-jsr305-with-jspecify

Conversation

@sfc-gh-alhuang

Copy link
Copy Markdown
Contributor

Summary

Replaces the javax.annotation (jsr305) nullability annotations with org.jspecify.annotations, so the shaded jar no longer contains jsr305 classes.

Why

jsr305 is EOL and Informatica's third-party library policy rejects it. It was being relocated inside the shaded jar (35 classes).

Mechanism

jsr305 reached the shaded jar from two sources: the SDK's direct optional dependency, and a transitive dependency via google-auth-library-oauth2-http 1.29.0, which the direct declaration was hiding.

Change

  • 13 Nullable/Nonnull imports swapped to org.jspecify.annotations
  • jspecify 1.0.0 added
  • jsr305 dependency removed
  • jsr305 excluded from google-auth-library-oauth2-http

Result

mvn clean package -DskipTests passes and the shaded jar has 0 javax/annotation entries.

Compatibility

  • No binary API change: the annotations were already relocated to an internal package in the shaded jar.
  • The unshaded artifact now gets jspecify as a regular dependency.

Testing

  • Build passes; shaded jar has 0 javax/annotation entries.
  • Local unit test runs (logs in /tmp/triage-2026-11-13/SNOW-4512105-test*.log) were not fully green. Per the logs: one run of 114 tests had 2 errors and 2 skipped, and a later rerun of InternalStageTest (11 tests) had 1 error. Every error I inspected there was InaccessibleObject (JDK module --add-opens for java.nio.file / java.util.concurrent), which is a local JVM-flag problem, not a failure caused by this change. The first run (many errors) and a fourth log were not clean either and were not analysed further.
  • OAuthBasicTest not run locally (needs qa1).
  • CI not yet run.

Links

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.60%. Comparing base (f5d4f8d) to head (55370a2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   61.57%   61.60%   +0.02%     
==========================================
  Files         214      214              
  Lines       14674    14674              
  Branches     1614     1614              
==========================================
+ Hits         9036     9040       +4     
+ Misses       4926     4922       -4     
  Partials      712      712              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-alhuang
sfc-gh-alhuang enabled auto-merge (squash) November 17, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants