Skip to content

[NO-SNOW] Make CI Happy - #1167

Merged
sfc-gh-yelgabra merged 8 commits into
masterfrom
yelgabra-NO-SNOW-jacoco-exclude-jmh
Aug 31, 2026
Merged

sfc-gh-yelgabra merged 8 commits into
masterfrom
yelgabra-NO-SNOW-jacoco-exclude-jmh

Conversation

@sfc-gh-yelgabra

@sfc-gh-yelgabra sfc-gh-yelgabra commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • FlushRowsBenchmarkTest was added in [SNOW-3883414] parquet compression corruption check #1162 but was replaced by ThroughputBenchmarkIT in the same pr, deleted now.
  • InsertRowsBenchmarkTest fork initialized both children to enableIcebergStreaming: false (default), this was fixed
  • TelemetryThreadPool in JDBC 3.25.1 keeps client alive for 30seconds which triggers JMH timeout and subsequent JaCoCo dumb truncation and CI failure, this was fixed by backporting JDBC 3.26.0 fix where hte pool is now daemoned

sfc-gh-yelgabra and others added 2 commits August 27, 2026 18:33
…generate

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@sfc-gh-yelgabra
sfc-gh-yelgabra requested review from a team as code owners August 27, 2026 19:27

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

Trial: port JDBC 3.26 SNOW-2226852 so InsertRowsBenchmarkTest does not sit
30s on idle non-daemon uploaders and get force-killed mid JaCoCo dump.

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

FlushRows was a manual readback compare, not a CI canary. JUnit
@parameterized never reached the JMH fork, so InsertRows always benched
FDN twice; @PARAM makes the child JVM actually run FDN and Iceberg.
channel.close() was not throwing in CI; the JMH hang was TelemetryThreadPool.

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

@sfc-gh-yelgabra sfc-gh-yelgabra changed the title [NO-SNOW] Ignore FlushRowsBenchmarkTest in default CI [NO-SNOW] Make CI Happy Aug 27, 2026
…h works

Iceberg JMH @PARAM hits ChannelCache.setNeedFlush; without addChannel the
table is missing and launchBenchmark fails on every cloud.
@codecov-commenter

codecov-commenter commented Aug 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.89%. Comparing base (38a6d6b) to head (fe567ba).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
+ Coverage   55.82%   60.89%   +5.06%     
==========================================
  Files         214      214              
  Lines       14616    14674      +58     
  Branches     1606     1614       +8     
==========================================
+ Hits         8160     8936     +776     
+ Misses       5859     5042     -817     
- Partials      597      696      +99     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* allowing the pool to shrink back to zero during periods of inactivity.
*/
private TelemetryThreadPool() {
// Daemon so client.close() → telemetry.flush does not pin the process for keepAliveTime.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you link me the file in the jdbc -- want to make sure this is exactly what jdbc is dong

@sfc-gh-yelgabra sfc-gh-yelgabra Aug 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the telemetry pr that introduced the daemon fix: snowflakedb/snowflake-jdbc#2297

what is currently in telemetry's repo: https://github.com/snowflakedb/snowflake-jdbc/blob/56e500b5e791ebbc9c17733a0b951abfa86a89b8/src/main/java/net/snowflake/client/internal/jdbc/telemetryOOB/TelemetryThreadPool.java#L4

both of them are exactly the same as this pr's backport

@sfc-gh-yelgabra
sfc-gh-yelgabra enabled auto-merge (squash) August 31, 2026 17:17
@sfc-gh-yelgabra
sfc-gh-yelgabra merged commit 849806f into master Aug 31, 2026
50 of 51 checks passed
@sfc-gh-yelgabra
sfc-gh-yelgabra deleted the yelgabra-NO-SNOW-jacoco-exclude-jmh branch August 31, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants