Repository navigation
[SNOW-3249917] Port 25 missing JDBC unit tests for replicated classes - #1147
Merged
Merged
Conversation
sfc-gh-ggeng
force-pushed
the
jdbc-removal-port-missing-tests
branch
from
April 7, 2026 21:29
2826354 to
2631868
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11d-demote-jdbc-v2
branch
2 times, most recently
from
April 7, 2026 23:15
6cba4fd to
cf20935
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-port-missing-tests
branch
from
April 7, 2026 23:15
2631868 to
b2c074b
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11d-demote-jdbc-v2
branch
from
April 8, 2026 02:32
cf20935 to
6b3b7a5
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-port-missing-tests
branch
2 times, most recently
from
April 8, 2026 05:35
217d987 to
1919bab
Compare
Port unit tests from snowflake-jdbc v3.25.1 for all replicated classes that had JDBC tests but were missing ingest tests. All converted from JUnit 5 to JUnit 4 to match project test infrastructure. Tests ported: - Security: SecretDetectorTest (masking), EncryptionProviderTest (CBC), GcmEncryptionProviderTest (GCM) - HTTP: RestRequestTest (retry/backoff), JdbcHttpUtilTest (client build), AttributeEnhancingHttpRequestRetryHandlerTest, HeaderCustomizerHttpRequestInterceptorTest, URLUtilTest - Storage: AwsSdkGCPSignerTest, SnowflakeAzureClientTest, SnowflakeS3ClientTest, StageInfoGcsCustomEndpointTest - Core: FileCacheManagerTest, ObjectMapperFactoryTest, ExecTimeTelemetryDataTest, SnowflakeFileTransferConfigTest, SnowflakeConnectStringTest - Logging: EventHandlerTest, EventTest, SFFormatterTest, SFLoggerFactoryTest, JDK14LoggerTest (@ignore) - Telemetry: TelemetryServiceOOBTest, TelemetryThreadPoolTest, TelemetryJsonTest 1 test @ignore'd: FileCacheManagerTest.throwWhenOverrideCacheFile... (requires mockito-inline for Mockito.mockStatic; project uses PowerMock) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfc-gh-ggeng
force-pushed
the
jdbc-removal-port-missing-tests
branch
from
April 8, 2026 17:50
1919bab to
9924edf
Compare
- Add hamcrest-core:1.3 as explicit test dependency (used by ported tests: RestRequestTest, JdbcHttpUtilTest, SnowflakeConnectStringTest, SecretDetectorTest) - Exclude vulnerable transitive deps from snowflake-jdbc-thin in both main pom and e2e-jar-test pom: - grpc-netty-shaded (CVE-2025-55163, CVSS 8.7) - commons-lang3 (CVE-2025-48924, CVSS 8.8) - javax.servlet-api (license: CDDL-1.1/GPL-2.0) - javax.annotation-api (license: CDDL-1.1/GPL-2.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfc-gh-ggeng
force-pushed
the
jdbc-removal-port-missing-tests
branch
from
April 8, 2026 17:55
8db4032 to
5eaa987
Compare
This was referenced Apr 8, 2026
sfc-gh-alhuang
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port unit tests from snowflake-jdbc v3.25.1 for all 25 replicated classes that had JDBC tests but were missing ingest tests. All converted from JUnit 5 to JUnit 4 to match project test infrastructure.
25 files added, +3514 lines
Security & Crypto (3)
SecretDetectorTest— secret masking (SAS tokens, passwords, credentials)EncryptionProviderTest— AES-CBC encrypt/decrypt round-tripGcmEncryptionProviderTest— AES-GCM encrypt/decrypt round-tripHTTP Infrastructure (5)
RestRequestTest— HTTP retry/backoff logicJdbcHttpUtilTest— HTTP client build race conditionAttributeEnhancingHttpRequestRetryHandlerTest— retry handler attributesHeaderCustomizerHttpRequestInterceptorTest— HTTP header customizationURLUtilTest— URL validation and request ID extractionStorage Clients (4)
AwsSdkGCPSignerTest— GCS signer header mappingSnowflakeAzureClientTest— Azure error info formattingSnowflakeS3ClientTest— S3 domain suffixStageInfoGcsCustomEndpointTest— GCS custom endpoint parameterizedCore (5)
FileCacheManagerTest— OCSP cache file permissions (26 tests, 1 @ignore)ObjectMapperFactoryTest— ObjectMapper max string lengthExecTimeTelemetryDataTest— execution time telemetry generationSnowflakeFileTransferConfigTest— config builder patternSnowflakeConnectStringTest— connection string account parsingLogging (5)
EventHandlerTest— event publish/flushEventTest— event type/dumpSFFormatterTest— UTC timestamp formattingSFLoggerFactoryTest— default logger creationJDK14LoggerTest— @ignore (same as JDBC)Telemetry (3)
TelemetryServiceOOBTest— OOB telemetry enable/disable/connection stringTelemetryThreadPoolTest— thread pool scalingTelemetryJsonTest— JSON conversionNotes
@Ignored:FileCacheManagerTest.throwWhenOverrideCacheFileHasDifferentOwnerThanCurrentUserTestrequiresmockito-inlineforMockito.mockStatic(); project usesmockito-core+ PowerMockSFSessionProperty.ACCOUNTnot replicated in ingest (only proxy properties); replaced with string constant"ACCOUNT"inSnowflakeConnectStringTestStacked on #1146.
Test plan
mvn test-compilepasses./format.shpasses🤖 Generated with Claude Code