Skill/module to migrate JSP pages to Thymeleaf#336
Closed
ammachado wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a JSP-to-Thymeleaf intermediate migration module to the Spring Boot → Quarkus skill flow, enabling JSP-based Spring MVC apps to be migrated via Thymeleaf before the existing Thymeleaf → Qute step.
Changes:
- Documented distinct migration paths (JSP→Thymeleaf→Qute, Thymeleaf→Qute, REST).
- Introduced a new
frontend-jspmodule and updated module gating/order to run it before the existing frontend module. - Added a Maven execution logging guideline (
--no-transfer-progress) to the orchestrator skill.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .claude/skills/spring-boot-to-quarkus-orchestrator/SKILL.md | Adds a Maven execution guideline to keep logs clean. |
| .claude/skills/migrate-spring-to-quarkus/SKILL.md | Updates the overall migration flow with a new JSP path and frontend-jsp module ordering/gates. |
| .claude/skills/migrate-spring-to-quarkus/modules/frontend-jsp.md | New module defining JSP → Thymeleaf migration steps and guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - [ ] Add `spring-boot-starter-thymeleaf` dependency to `pom.xml` | ||
| - [ ] Convert JSP files to Thymeleaf `.html` templates | ||
| - [ ] Move templates from `webapp/WEB-INF/jsp/` to `resources/templates/` |
|
|
||
| ## Why Migrate from JSP to Thymeleaf? | ||
|
|
||
| JSP is not supported in Quarkus. The migration path is: **JSP → Thymeleaf → Qute**. Thymeleaf is an intermediate step that allows testing the application in Spring Boot before final Quarkus migration. Reference the [Frontend module](@frontend.md) when performing the migration. |
| | `<c:choose><c:when test="${x}">...<c:otherwise>` | `<div th:if="${x}">...<div th:unless="${x}">` | Conditional switch | | ||
| | `<fmt:formatDate value="${date}" pattern="yyyy-MM-dd"/>` | `<span th:text="${#dates.format(date, 'yyyy-MM-dd')}"/>` | Date formatting | | ||
| | `<fmt:formatNumber value="${price}" pattern="#,##0.00"/>` | `<span th:text="${#numbers.formatDecimal(price, 1, 2)}"/>` | Number formatting | | ||
| | `<c:url value="/path/${id}"/>` | `<a th:href="@{/path/{id}(id=${item.id})}">` | URL with path variable | |
| - **Java code**: Search for Spring annotations (DI, REST, Data, Security, Scheduling) | ||
| - **Configuration**: Read `application.properties`/`application.yml`, check for profiles | ||
| - **UI / View layer**: Check for Thymeleaf/JSP templates, static resources, Model+View patterns | ||
| - **UI / View layer**: Check for JSP templates in `webapp/WEB-INF/jsp/` or `webapp/WEB-INF/views/`, Thymeleaf templates in `templates/`, static resources, Model+View patterns |
ammachado
force-pushed
the
features/jsp-migration-skill
branch
from
e953dff to
33da739
Compare
Author
|
Moving this PR to quarkusio/skills#12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.