fix(ItemBar): 아이템 버튼 초기화 로직 개선#392
Merged
Merged
Conversation
- 기존 버튼을 반드시 제거하도록
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ItemBar class to clear and destroy existing buttons before re-initializing the item list. The review feedback points out that button.destroy() should be called with { children: true } to ensure all nested PixiJS objects are properly disposed of, which prevents potential memory leaks.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 개요
📋 변경 및 추가 사항
아이템 버튼이 여러 개 그려지는 문제가 있었습니다
게스트 플레이일 때 그려졌던 아이템 버튼이 남아있음..!!
ItemBar에서 아이템 버튼을 생성할 때 기존 버튼을 정리하는 로직을 추가했어용💬 To. 리뷰어