Support DateTimeInterface (requires PHP > 5.5)#12
Open
acoulton wants to merge 1 commit intosmirik:masterfrom
Open
Support DateTimeInterface (requires PHP > 5.5)#12acoulton wants to merge 1 commit intosmirik:masterfrom
acoulton wants to merge 1 commit intosmirik:masterfrom
Conversation
Allow passing in either a DateTime or a DateTimeImmutable by typehinting as the DateTimeInterface added in PHP5.5. Bumps the bare minimum PHP version to 5.5.x (though all the 5.x series are no longer supported anyway) and updates composer and travis to officially test and support on 7.x. This is backwards compatible for anyone simply using the class, but is arguably a breaking change if anyone has extended the class as the method signature of the ->get method has changed and will produce an incompatible signatures warning...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing in either a DateTime or a DateTimeImmutable by
typehinting as the DateTimeInterface added in PHP5.5.
Bumps the bare minimum PHP version to 5.5.x (though all the 5.x
series are no longer supported anyway) and updates composer and
travis to officially test and support on 7.x.
This is backwards compatible for anyone simply using the class,
but is arguably a breaking change if anyone has extended the class
as the method signature of the ->get method has changed and will
produce an incompatible signatures warning...