Make pynest installable via pip, split pynest.py into an main program and a library, and move from urllibX to requests#9
Open
rbpasker wants to merge 4 commits into
Open
Conversation
FiloSottile
added a commit
to FiloSottile/nest_thermostat
that referenced
this pull request
Mar 8, 2014
|
Merged in my fork: https://github.com/FiloSottile/nest_thermostat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a fairly extensive change, but its actually rather modest and doesn't include any of my own app-specific code
split pynest.py into a main program and a library. this has been done numerous times in various forks. I think my commit is the minimal necessary to make it a useful
created a package for the pynest library, and pynest easily installed via pip:
% pip install git+https://github.com/Tengah/pynest (or whatever your github repo is)
it will now be now super easy to add pynest to https://pypi.python.org/
convert urllibX to the much simpler and more modern python requests: http://www.python-requests.org/
DRY'd set_fan and set_temperature
feedback welcome