Fix: Added Unlink option to Circular Dependency warning dialog (#7)#8
Open
ventura0121 wants to merge 1 commit intosmartqubit:masterfrom
Open
Fix: Added Unlink option to Circular Dependency warning dialog (#7)#8ventura0121 wants to merge 1 commit intosmartqubit:masterfrom
ventura0121 wants to merge 1 commit intosmartqubit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a usability "trap" within the Gantt chart and dependency management logic (ref: Issue #7). Currently, when a user creates a circular dependency, the system displays a static error message that lacks an immediate resolution path, forcing the user to manually hunt for and delete the link.
Changes
Actionable Dialog: Modified the GanttInteractor and DependencyDialog error handling blocks to replace the standard Alert with a JOptionPane choice dialog.
Escape Hatch: Added an "Unlink Tasks" option that allows the user to immediately revert the invalid dependency from within the warning dialog.
Code Integrity: Followed existing Java Swing patterns and naming conventions to ensure the UI remains consistent with the legacy codebase.
Impact
This improvement follows UX best practices by providing "user control and freedom" (Heuristic #3). For construction project managers dealing with complex, multi-thousand-row schedules, this small change prevents workflow disruption and reduces the risk of accidental data corruption in the schedule logic.
Fixes: #7