Skip to content
This repository was archived by the owner on Jul 5, 2022. It is now read-only.

Fixes#13

Open
aelmanaa wants to merge 1 commit intomainfrom
aelmanaa/fix-build-issues
Open

Fixes#13
aelmanaa wants to merge 1 commit intomainfrom
aelmanaa/fix-build-issues

Conversation

@aelmanaa
Copy link
Contributor

  • Fix github actions
  • Rely on forge-std for testing rather than dapphub ds-test . the former extends the latter and adds additional functions
  • Fix contracts to reduce the number of solhint and solidity compiler warnings
  • Remove dapp commands and dependencies. We should rely only on Foundry
  • Increase the verbosity level for testing (3 instead of 0) in order to get the stack trace in case of issues. ref

…Remove dapp commands and configuration. Use forge-std for testing
@aelmanaa aelmanaa requested a review from PatrickAlphaC April 23, 2022 16:39
@aelmanaa aelmanaa self-assigned this Apr 23, 2022
@PatrickAlphaC
Copy link
Contributor

This is great!!

@PatrickAlphaC
Copy link
Contributor

Can you fix the merge conflicts? I added some stuff before I saw this PR...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants