refactor: roll out the CctActions/EoaExecutor action layer across the remaining write scripts#6
Merged
SyedAsadKazmi merged 2 commits intoJul 9, 2026
Conversation
… remaining write scripts
|
👋 aelmanaa, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
SyedAsadKazmi
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors several deployment and configuration scripts to standardize how contract calls are executed and to improve maintainability. The main change is to abstract direct contract interactions behind a new actions/executor pattern, removing repetitive error handling and broadcast logic from the scripts themselves. This results in more concise, consistent, and testable scripts.
Refactor to actions/executor pattern:
EoaExecutorinstead ofScript, and use theexecuteCallsmethod withCctActionsto perform contract interactions, replacing direct calls and manual broadcast/error handling. (script/configure/allowlist/UpdateAdvancedPoolHooks.s.sol,script/configure/allowlist/UpdateAllowList.s.sol,script/configure/authorized-callers/UpdateAuthorizedCallers.s.sol,script/configure/dynamic-config/SetDynamicConfig.s.sol,script/configure/fee-config/UpdateTokenTransferFeeConfig.s.sol,script/configure/finality-config/SetFinalityConfig.s.sol) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]Simplification and code cleanup:
vm.startBroadcast(),vm.stopBroadcast(), andtry/catcherror handling blocks from scripts, centralizing error handling in the executor/actions pattern. [1] [2] [3] [4] [5] [6] [7] [8] [9]broadcaster()) instead of direct tuple unpacking for cleaner code.Dependency and interface updates:
CctActionsandEoaExecutor. [1] [2] [3] [4] [5] [6]These changes make the scripts more modular and easier to maintain, while ensuring consistent execution and error reporting across all configuration and deployment scripts.