Skip to content

refactor: roll out the CctActions/EoaExecutor action layer across the remaining write scripts#6

Merged
SyedAsadKazmi merged 2 commits into
mainfrom
refactor/action-layer-rollout-configure-hooks-operations
Jul 9, 2026
Merged

refactor: roll out the CctActions/EoaExecutor action layer across the remaining write scripts#6
SyedAsadKazmi merged 2 commits into
mainfrom
refactor/action-layer-rollout-configure-hooks-operations

Conversation

@aelmanaa

@aelmanaa aelmanaa commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This pull request refactors several deployment and configuration scripts to standardize how contract calls are executed and to improve maintainability. The main change is to abstract direct contract interactions behind a new actions/executor pattern, removing repetitive error handling and broadcast logic from the scripts themselves. This results in more concise, consistent, and testable scripts.

Refactor to actions/executor pattern:

  • All scripts now inherit from EoaExecutor instead of Script, and use the executeCalls method with CctActions to perform contract interactions, replacing direct calls and manual broadcast/error handling. (script/configure/allowlist/UpdateAdvancedPoolHooks.s.sol, script/configure/allowlist/UpdateAllowList.s.sol, script/configure/authorized-callers/UpdateAuthorizedCallers.s.sol, script/configure/dynamic-config/SetDynamicConfig.s.sol, script/configure/fee-config/UpdateTokenTransferFeeConfig.s.sol, script/configure/finality-config/SetFinalityConfig.s.sol) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]

Simplification and code cleanup:

  • Removed manual vm.startBroadcast(), vm.stopBroadcast(), and try/catch error handling blocks from scripts, centralizing error handling in the executor/actions pattern. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Updated scripts to use helper functions (e.g., broadcaster()) instead of direct tuple unpacking for cleaner code.

Dependency and interface updates:

  • Removed direct imports of contract interfaces and replaced with imports of CctActions and EoaExecutor. [1] [2] [3] [4] [5] [6]

These changes make the scripts more modular and easier to maintain, while ensuring consistent execution and error reporting across all configuration and deployment scripts.

@aelmanaa aelmanaa requested review from a team as code owners July 8, 2026 17:44
@aelmanaa aelmanaa requested a review from SyedAsadKazmi July 8, 2026 17:44
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

👋 aelmanaa, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@SyedAsadKazmi SyedAsadKazmi merged commit 229c580 into main Jul 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants