Skip to content

Update chainlink-aptos and aptos capability to correctly classify user errors - #23997

Merged
yashnevatia merged 5 commits into
developfrom
aptos-cap-view-user-error
Oct 15, 2026
Merged

yashnevatia merged 5 commits into
developfrom
aptos-cap-view-user-error

Conversation

@yashnevatia

@yashnevatia yashnevatia commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What:

  • Bumping chainlink-aptos which introduces this change, where we basically catch 400 errors and send it as InvalidArgument in the aptos service
  • Bumping aptos capability which introduces this change, which catches the InvalidArgument and classifies that as UserError.

Testing Criteria:

  • E2E test covers this scenario
  • But to be extra sure deploy a dummy workflow in staging after change is released with incorrect contract address and check if Aptos View Error goes up (it should not)

@github-actions

Copy link
Copy Markdown
Contributor

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@yashnevatia yashnevatia changed the title Update chainlink-aptos Update chainlink-aptos and aptos capability to correctly classify user errors Oct 15, 2026
@cl-sonarqube-production

Copy link
Copy Markdown

@yashnevatia
yashnevatia enabled auto-merge October 15, 2026 19:18
@yashnevatia
yashnevatia added this pull request to the merge queue Oct 15, 2026
Merged via the queue into develop with commit 5931a1a Oct 15, 2026
147 checks passed
@yashnevatia
yashnevatia deleted the aptos-cap-view-user-error branch October 15, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants