Conversation
|
👋 bolekk, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
bolekk
changed the title
jmank88
reviewed
Feb 27, 2026
pkg/settings/settings.go
Outdated
| if t, err := time.Parse(time.RFC3339, s); err == nil { | ||
| return t, nil | ||
| } | ||
| return time.Parse("2006-01-02 15:04:05 -0700 MST", s) // Go default format |
Contributor
There was a problem hiding this comment.
The package docs show 2006-01-02 15:04:05.999999999 -0700 MST. Is the extra precision omitted intentionally? Is that ok?
jmank88
previously approved these changes
Feb 27, 2026
bolekk
force-pushed
the
fix_time_parsing
branch
from
f5b6aa8 to
fe717b1
Compare
jmank88
approved these changes
Feb 27, 2026
justinkaseman
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept two formats