Execution timestamp setting + new execution IDs feature flag#1857
Merged
Execution timestamp setting + new execution IDs feature flag#1857
Conversation
✅ API Diff Results - No breaking changes |
bolekk
changed the title
bolekk
force-pushed
the
flag_for_dontime_timestamps
branch
from
c48e662 to
6944079
Compare
bolekk
changed the title
bolekk
changed the title
bolekk
changed the title
jmank88
requested changes
Feb 27, 2026
bolekk
force-pushed
the
flag_for_dontime_timestamps
branch
from
692c259 to
a425a7c
Compare
bolekk
force-pushed
the
flag_for_dontime_timestamps
branch
from
a425a7c to
cfcba42
Compare
jmank88
reviewed
Feb 27, 2026
jmank88
reviewed
Feb 27, 2026
jmank88
reviewed
Feb 27, 2026
pkg/settings/limits/bound.go
Outdated
| scope: bound.GetScope(), | ||
| key: bound.GetKey(), | ||
| scope: bound.GetScope(), | ||
| isUpperBound: isUpperBound, |
Contributor
There was a problem hiding this comment.
nit/ isLowerBound would be a bit smoother (and less risky) since the zero value is the old behavior 🤷
jmank88
reviewed
Feb 27, 2026
jmank88
reviewed
Feb 27, 2026
Contributor
|
🤔 Does this mean that adding a new feature flag requires a code change to this schema every time? |
Contributor
Yes. Deployments needs to understand the schema in order to validate the settings before distributing them. We could maybe skip this repo if we split up cresettings in to sub-sections owned by each repo for themselves, but it would take a lot of additional refactoring in deployments and probably core to make that transition. |
bolekk
force-pushed
the
flag_for_dontime_timestamps
branch
from
cfcba42 to
97f6205
Compare
bolekk
force-pushed
the
flag_for_dontime_timestamps
branch
from
97f6205 to
e13136c
Compare
jmank88
approved these changes
Feb 27, 2026
cedric-cordenier
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
(2) needs (1) to be enabled first (see core PR)