feat(onchain): Always execute OOO; Ignore allowOOOExecution in extraArgs#355
Open
rodrigombsoares wants to merge 1 commit intodevelopfrom
Open
feat(onchain): Always execute OOO; Ignore allowOOOExecution in extraArgs#355rodrigombsoares wants to merge 1 commit intodevelopfrom
rodrigombsoares wants to merge 1 commit intodevelopfrom
Conversation
rodrigombsoares
temporarily deployed
to
integration
GitHub Actions
Inactive
rodrigombsoares
force-pushed
the
ignore-ooo-extraargs
branch
from
82ec984 to
70a353e
Compare
rodrigombsoares
temporarily deployed
to
integration
GitHub Actions
Inactive
rodrigombsoares
commented
Feb 27, 2026
Comment on lines
-614
to
-620
| let nonce = | ||
| if (is_out_of_order_execution) { 0 } | ||
| else { | ||
| nonce_manager::get_incremented_outbound_nonce( | ||
| &state_signer, dest_chain_selector, sender | ||
| ) | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
This change here is optional, in theory fee_quoter::process_message_args will always return true for is_out_of_order_execution.
But I feel like removing this gate is safer. WDYT @cfal @friedemannf?
Contributor
There was a problem hiding this comment.
I like this change! It in fact does mean you can fully remove the nonce manager as well
JohnChangUK
reviewed
Feb 27, 2026
| // If extra args are empty, generate default values. | ||
| (dest_chain_config.default_tx_gas_limit as u256, false) | ||
| // If extra args are empty, generate default values. Out-of-order is always true. | ||
| (dest_chain_config.default_tx_gas_limit as u256, true) |
Contributor
There was a problem hiding this comment.
Can we have a const for ALLOW_OOO_EXECUTION and replace true with this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes out-of-order execution always true on Aptos CCIP by ignoring the user’s value in extra args and overriding it to
true.The contract still parses extra args as before but always treats/returns OOO as true and never reverts on the user’s choice, so existing users who omit the flag or set it to false are not broken.
Features
allow_out_of_order_execution == falsetrue(default_tx_gas_limit, true)enforce_out_of_orderremains in DestChainConfig for compatibility but is no longer used for any check.Testing
test_out_of_order_execution_requiredinfee_quoter_chain_family.movewas updated to expect success when the user sendscreate_extra_args(500000, false), and to assert thatprocess_message_argsreturnsis_out_of_order_execution == true.To run tests:
cd contracts/ccip/ccipaptos move test --devJira
https://smartcontract-it.atlassian.net/browse/NONEVM-3792