Skip to content

chain_capabilities/*/monitoring: remove redundant logged metrics - #825

Open
jmank88 wants to merge 1 commit into
mainfrom
log-noise-evm-monitoring
Open

jmank88 wants to merge 1 commit into
mainfrom
log-noise-evm-monitoring

Conversation

@jmank88

@jmank88 jmank88 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The [<chain family> Monitoring] log message is one of our noisiest. This PR proposes removing them since they are redundant anyways (emitted as metrics).

@github-actions

Copy link
Copy Markdown
Contributor

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@jmank88
jmank88 requested a review from Unheilbar October 15, 2026 19:47
Unheilbar
Unheilbar previously approved these changes Oct 15, 2026
@jmank88
jmank88 enabled auto-merge October 15, 2026 20:08
pavel-raykov
pavel-raykov previously approved these changes Oct 15, 2026
@jmank88
jmank88 dismissed stale reviews from pavel-raykov and Unheilbar via 0ca32f9 October 15, 2026 20:28
@jmank88
jmank88 force-pushed the log-noise-evm-monitoring branch from fef26d7 to 0ca32f9 Compare October 15, 2026 20:28
@jmank88 jmank88 changed the title chain_capabilities/evm/monitoring: reduce log level; specific message chain_capabilities/*/monitoring: remove redundant logged metrics Oct 15, 2026
@jmank88
jmank88 requested a review from ilija42 October 15, 2026 20:29
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jmank88
jmank88 requested a review from pavel-raykov October 15, 2026 20:33

@ilija42 ilija42 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing logMessage drops all logs for ViewInitiated and WriteReportInitiated.
Success and Error messages still get a log line from LogAndEmitSuccess / LogAndEmitError. Initiated messages go through EmitInitiated, which does not log. The processor line was their only log.

We should add a LogAndEmitInitiated helper, same shape as LogAndEmitSuccess, and use it in the two Aptos call sites. Both Initiated types already have LogAttributes().

@jmank88
jmank88 disabled auto-merge October 15, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants