Repository navigation
Conversation
|
👋 jmank88, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
fef26d7 to
0ca32f9
Compare
|
ilija42
left a comment
There was a problem hiding this comment.
Removing logMessage drops all logs for ViewInitiated and WriteReportInitiated.
Success and Error messages still get a log line from LogAndEmitSuccess / LogAndEmitError. Initiated messages go through EmitInitiated, which does not log. The processor line was their only log.
We should add a LogAndEmitInitiated helper, same shape as LogAndEmitSuccess, and use it in the two Aptos call sites. Both Initiated types already have LogAttributes().





The
[<chain family> Monitoring]log message is one of our noisiest. This PR proposes removing them since they are redundant anyways (emitted as metrics).