Repository navigation
Move to dependency injection for PSBs - #824
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Nil-constructor validation and capability-specific configuration support need to be restored.
2 open findings
What changed in this PR
Migrates the PSB capability runner from reflection-based constructors to dependency injection using samber/do.
Changes:
- Introduces typed constructors and injector-provided runtime dependencies.
- Removes reflection-based dependency resolution and capability configuration binding.
- Adapts runner and telemetry tests to the new constructor signature.
| File | Description |
|---|---|
| libs/go.sum | Adds dependency checksums. |
| libs/go.mod | Declares dependency injection packages. |
| libs/capability/telemetry_test.go | Updates test constructors. |
| libs/capability/runner.go | Creates and populates the injector. |
| libs/capability/runner_test.go | Adapts lifecycle tests. |
| libs/capability/run.go | Switches public APIs to typed constructors. |
| libs/capability/run_test.go | Revises constructor and dependency tests. |
| libs/capability/capability.go | Removes configuration markers and dependency resolution helpers. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cedric-cordenier
previously approved these changes
Oct 15, 2026
|
cedric-cordenier
approved these changes
Oct 15, 2026
nolag
marked this pull request as ready for review
October 15, 2026 19:17
DylanTinianov
approved these changes
Oct 15, 2026
nolag
enabled auto-merge
October 15, 2026 19:17
product-security-plaid-production
Bot
requested review from
bolekk,
prashantkumar1982 and
yashnevatia
October 15, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.