Repository navigation
Validate Max Aggregatable Exponent Consensus - #822
Open
silaslenihan wants to merge 1 commit into
Open
silaslenihan wants to merge 1 commit into
silaslenihan wants to merge 1 commit into
Conversation
|
silaslenihan
marked this pull request as ready for review
October 15, 2026 15:21
product-security-plaid-production
Bot
requested review from
Unheilbar,
cedric-cordenier and
ilija42
October 15, 2026 15:21
silaslenihan
enabled auto-merge
October 15, 2026 16:46
Unheilbar
approved these changes
Oct 15, 2026
yashnevatia
reviewed
Oct 15, 2026
| return fmt.Errorf("observation from observer %d is missing input for request %s", ao.Observer, requestID) | ||
| } | ||
|
|
||
| if valueInput, ok := reqObs.Input.GetObservation().(*sdk.SimpleConsensusInputs_Value); ok { |
Contributor
There was a problem hiding this comment.
@silaslenihan is this valueInput coming from the user ? Asking because if we return error here, one user's bad input can kill the round observation of all nodes ?
yashnevatia
reviewed
Oct 15, 2026
| func(val *valuespb.Value) (decimal.Decimal, error) { | ||
| var d decimal.Decimal | ||
| if exp := val.GetDecimalValue().GetExponent(); exp > maxDecimalExponent || exp < -maxDecimalExponent { | ||
| if exp := val.GetDecimalValue().GetExponent(); exp > MaxAggregatableExponent || exp < -MaxAggregatableExponent { |
Contributor
There was a problem hiding this comment.
will this ever happen if we ValidateObservation ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.