Repository navigation
Conversation
|
| // duplicate registration raises into an error - here it is the operator's binary, not init, that | ||
| // would be crashing. | ||
| func registerAll[T any](name string, config ConfigProvider[T]) (err error) { | ||
| defer func() { |
Contributor
There was a problem hiding this comment.
Why do we have a recover here?
| // TODO: pass in constructors here for our runnable/embeddable dependencies? | ||
| // Something else here | ||
| return run(cmd.Context(), lggr, cmd.Root().Name(), cfg, c) | ||
| cfg := embedRegistrations.configs[""].value.(*embedConfig) |
Contributor
There was a problem hiding this comment.
Not sure what this is
| mux := http.NewServeMux() | ||
|
|
||
| httpCfg := cfg.http | ||
| httpCfg.Port += uint16(instance.ID) |
Contributor
There was a problem hiding this comment.
This should default to 0 and we'll just grab an open port
|
|
||
| func (f *fakeBroadcaster) Subscribe(context.Context) (<-chan core.SettingsUpdate, error) { | ||
| // Subscribe hands out a stream that, like a real one, ends when the subscription's ctx does. | ||
| func (f *fakeBroadcaster) Subscribe(ctx context.Context) (<-chan core.SettingsUpdate, error) { |
Contributor
There was a problem hiding this comment.
There's a lot of extra complexity here -- why?
nolag
commented
Oct 15, 2026
| @@ -0,0 +1,19 @@ | |||
| // Command docgen is a capability binary run only for its docs command: it generates the | |||
Contributor
Author
There was a problem hiding this comment.
Not needed? Generating doc comments for struct provides nothing.
| // registerSettings registers the run's own settings, as any dependency registers its config, for | ||
| // RunErr to bind and start to resolve. capabilities differs between the commands: embed's has no | ||
| // proxy to dial and defaults the DON, and capabilityConfig is built from it. | ||
| func registerSettings() { |
Contributor
There was a problem hiding this comment.
rename settings -> config -- settings refers to cre settings specifically
nolag
commented
Oct 15, 2026
| // embeddedCapabilityConfig is capabilityConfig as an embed run registers it, replacing run's under | ||
| // the same namespace. It keeps the DON ID and drops the proxy URL: there is no node behind an | ||
| // embedded run to dial, so only what this binary hosts resolves. | ||
| type embeddedCapabilityConfig struct { |
Contributor
Author
There was a problem hiding this comment.
?? it's this hard-coded to the same value every time? Do we need it?
| telemetry TelemetryConfig | ||
| tracing TracingConfig | ||
| chipIngress ChipIngressConfig | ||
| pyroscope PyroscopeConfig |
Contributor
There was a problem hiding this comment.
Why was this removed?
nolag
commented
Oct 15, 2026
| root.AddCommand(&cobra.Command{ | ||
| // serve starts total instances from r and blocks until ctx is done. Only run hands the process | ||
| // to a go-plugin host: a host supervises one plugin, and an embed run is not one. | ||
| serve := func(cmd *cobra.Command, r *registrations, total int, pluginHost bool) error { |
Contributor
Author
There was a problem hiding this comment.
pluginHost doesn’t need to be a boolean, can just check underPluginHost it's harmless and fast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.