Fix: The buttons in the some menus do not make a clicking sound#1350
Open
Adem-Kurt wants to merge 4 commits intosmartcmd:mainfrom
Open
Fix: The buttons in the some menus do not make a clicking sound#1350Adem-Kurt wants to merge 4 commits intosmartcmd:mainfrom
Adem-Kurt wants to merge 4 commits intosmartcmd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The buttons in the Help and Options menu, Debug menu, Death menu and Pause menu make a clicking sound after this update.
Changes
Previous Behavior
The buttons in the Help and Options menu, Debug menu, Death menu and Pause menu do not play a clicking sound.
Root Cause
While the
handlePressfunction in other menus (such as Settings and Settings Options) have code that plays a click sound, but that code is not in the Help and Options menu, the Debug menu, the Death menu, or the Pause menuNew Behavior
The buttons in the Help and Options menu, Debug menu, Death menu and Pause menu play a clicking sound.
Fix Implementation
I added the line
ui.PlayUISFX(eSFX_Press);at the beginning of thehandlePressfunctions in the menu files (as inUIScene_SettingsMenu.cpp,UIScene_SettingsOptionsMenu.cpp, etc.).AI Use Disclosure
None
Related Issues