Increase max limits for boats and minecarts slightly, but not any wor…#1349
Closed
Jazzitch wants to merge 4 commits intosmartcmd:mainfrom
Closed
Increase max limits for boats and minecarts slightly, but not any wor…#1349Jazzitch wants to merge 4 commits intosmartcmd:mainfrom
Jazzitch wants to merge 4 commits intosmartcmd:mainfrom
Conversation
…ld height changes
Updated button label from 'Title menu' to 'Exit to Title Menu' and changed 'Game over!' to 'Game Over!' for consistency.
… have longer world names
Collaborator
|
Can you test behavior as to how much the limits for Minecarts and Boats can be safely raised? |
Contributor
Author
|
@mattsumi yeah, I'll comment on my new PR when I get home from work the screen shot of more boats + rails on the max. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the max limit for boats and minecarts by +10, and leaves the world height at 256 (the original, conservative value)
Changes
Previous Behavior
Minecarts and boats had a limit of 40.
Root Cause
The new boats and minecart limit was removed alongside with the world height revert (this PR keeps the world height at 256).
New Behavior
Minecarts and boats have a limit of 50 instead of 40, which can allow for builds that require minecarts and boats en masse.
Fix Implementation
Adding 10 to the limit of minecarts and boats.
AI Use Disclosure
No AI was used.
Related Issues