Skip to content

Revert "Increase limits for boats, minecarts, fireballs, and height"#1341

Merged
mattsumi merged 1 commit intomainfrom
revert-1325-main
Mar 19, 2026
Merged

Revert "Increase limits for boats, minecarts, fireballs, and height"#1341
mattsumi merged 1 commit intomainfrom
revert-1325-main

Conversation

@mattsumi
Copy link
Collaborator

@mattsumi mattsumi commented Mar 19, 2026

Reverts #1325.

This PR is being temporarily reverted because:

Good PR! However, we are unsure if build height is out of scope for this project.

Please submit a new PR for the other changes.

For the world height, I would prefer if you made it a setting, and not a permanent default.

Look at our CONTRIBUTING.md for more info.

@Jazzitch
Copy link
Contributor

Okay, so the extending limit for boats and minecarts is okay, but I'll have to decrease height? Just making sure.

@mattsumi
Copy link
Collaborator Author

Okay, so the extending limit for boats and minecarts is okay, but I'll have to decrease height? Just making sure.

Just keep the height as it is in vanilla behavior. If you want to keep it increased, please make it a setting, and not a default.

The other changes are accepted.

@mattsumi mattsumi merged commit ecb3f00 into main Mar 19, 2026
1 check passed
@Jazzitch
Copy link
Contributor

@mattsumi okay I opened a new PR: #1342

@GabsPuNs
Copy link
Contributor

GabsPuNs commented Mar 19, 2026

Okay, so the extending limit for boats and minecarts is okay, but I'll have to decrease height? Just making sure.

If extending the limits for boats and minecarts is allowed, maybe you could use the TU2x limits. The increased height have problems and is not allowed too.

@mattsumi mattsumi deleted the revert-1325-main branch March 19, 2026 00:57
@RussianHaxxer
Copy link

Oh come on, I liked the increased limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants