Fix: opening the horse's inventory plays sound effects twice#1336
Merged
mattsumi merged 1 commit intosmartcmd:mainfrom Mar 19, 2026
Merged
Fix: opening the horse's inventory plays sound effects twice#1336mattsumi merged 1 commit intosmartcmd:mainfrom
mattsumi merged 1 commit intosmartcmd:mainfrom
Conversation
3UR
approved these changes
Mar 18, 2026
Collaborator
|
Thank you for contributing! |
|
Yay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this update, pressing the inventory key while riding a horse, mule, or donkey would trigger the inventory sound effect twice.
Changes
Previous Behavior
Opening Horse inventory plays sound effect twice.
Root Cause
Previously, a sound effect was triggered when the player pressed the inventory key. Then, if the player was riding an animal, the open horse inventory logic would also trigger and play the same sound effect again.(
minecraft.cppline 3759 andLocalPlayer.cppline 630)New Behavior
Opening the horse inventory played the sound effect once.
Fix Implementation
Updated Minecraft.cpp to include a condition that checks whether the player is riding an animal before playing the sound effect.
AI Use Disclosure
AI was used as a search tool and to help format this PR message.
Related Issues