feat(fuel)!: Fuel data types from primitives to objects#143
Draft
wikiadrian wants to merge 1 commit intomasterfrom
Draft
feat(fuel)!: Fuel data types from primitives to objects#143wikiadrian wants to merge 1 commit intomasterfrom
wikiadrian wants to merge 1 commit intomasterfrom
Conversation
This is the change to update the data types is fuel endpoint to allow nulls when one or two of the fuel signals is empty. This change might break the customers when one of the signals return null from the Smartcar API server. Customer need to be aware to map correctly the null cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
=========================================
Coverage 68.91% 68.91%
Complexity 238 238
=========================================
Files 50 50
Lines 1007 1007
Branches 70 70
=========================================
Hits 694 694
Misses 279 279
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the change to update the data types is fuel endpoint to allow nulls when one or two of the fuel signals is empty.
This change might break the customers when one of the signals return null from the Smartcar API server. Customer need to be aware to map correctly the null cases.