feat(prompts): finish prompt surfaces — rug-pull approve ops + F9 tool arg - #1011
Merged
Conversation
…l arg Completes the prompt-aggregation feature at the MCP/REST level for release. - Rug-pull approve surface (spec 100 FR-7): quarantine_security gains inspect_prompts, approve_prompt, approve_all_prompts operations, delegating to the ApprovePrompt/ApproveAllPrompts mutators. A held (pending/changed) prompt is now approvable by an agent/operator via any MCP client instead of only programmatically or by flipping the server to trust:auto. - F9: the upstream_servers MCP tool gains the expose_prompts arg (add/patch), so the per-server prompt-aggregation override is reachable from the tool, not just the REST PATCH shipped in #1006. - Regenerated the three frozen tool-surface goldens for both schema additions (merge-base via the write-goldens env hook; pre099 via byte-preserving splice; prefeature via map update). - Docs: security-quarantine.md documents the prompt rug-pull baseline and the new quarantine_security prompt operations. Tests: quarantine_security prompt op handlers (inspect/approve/approve-all + missing-arg error) and the F9 patch-builder expose_prompts mapping. Fast-follow (Web UI): a per-server expose_prompts toggle and a rug-pull "N prompts need approval" banner in ServerDetail.vue (the latter needs REST twins). The feature is complete via MCP + REST; the operator UI is polish. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H7J8Yv5zr4tMQZaY3ot3Za
Deploying mcpproxy-docs with
|
| Latest commit: |
7e94984
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4b5195af.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://feat-finish-prompts.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 32279939896 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the prompt-aggregation feature at the MCP/REST level, so it's ready for release. Every finding from the original #973 multi-model review is now shipped and reachable.
What's here
quarantine_securitygainsinspect_prompts,approve_prompt,approve_all_prompts, delegating to theApprovePrompt/ApproveAllPromptsmutators shipped in the MVP. A held (pending/changed) prompt is now approvable by an agent or operator via any MCP client, not just programmatically or by flipping the server totrust: auto.upstream_serversMCP tool gains theexpose_promptsarg (add/patch), so the per-server override is reachable from the tool, not only the REST PATCH that shipped in feat(prompts): polish for upstream prompt aggregation (F6/F7, F9, F14, F15) #1006.security-quarantine.mdnow documents the prompt rug-pull baseline and the new operations.Tests
quarantine_securityprompt op handlers (inspect / approve / approve-all + missing-arg error) and the F9 patch-builderexpose_promptsmapping. Both editions build; v2 lint clean.Fast-follow (Web UI only)
A per-server
expose_promptstoggle and a rug-pull "N prompts need approval" banner inServerDetail.vue(the banner needs REST approve twins). The feature is fully usable via MCP + REST today; this is operator-UI polish, deliberately out of the release-blocking path.🤖 Generated with Claude Code