Skip to content

Add Tx.Tx accessor for the embedded *sql.Tx - #93

Merged
farhan687 merged 1 commit into
mainfrom
farhan/tx-accessor
Sep 28, 2026
Merged

farhan687 merged 1 commit into
mainfrom
farhan/tx-accessor

Conversation

@farhan687

@farhan687 farhan687 commented Sep 28, 2026 •

Copy link
Copy Markdown

Name of feature:

Add Tx.Tx accessor for the embedded *sql.Tx

Pain or issue this feature alleviates:

Inventory needs to insert River jobs in the same transaction as a tag change, so a notification can't be lost if the process dies between the two. River's database/sql driver (riverdatabasesql) inserts jobs into a *sql.Tx, but sequel.Tx keeps its transaction private, so there's no way to hand it over.

  • New func (t *Tx) Tx() *sql.Tx, returning the embedded *sql.Tx. It mirrors the existing DB.DB() accessor.

💔Thank you!

@farhan687
farhan687 requested a review from a team as a code owner September 28, 2026 16:01
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@farhan687
farhan687 merged commit abb7283 into main Sep 28, 2026
13 of 15 checks passed
@farhan687
farhan687 deleted the farhan/tx-accessor branch September 28, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants