Fix release workflow leaving permanent draft releases on GitHub#1652
Merged
Conversation
The release workflow was creating a GitHub draft release before goreleaser ran. goreleaser preserves the draft state of releases it didn't create itself, so every release was left as a permanent draft. Removes the pre-goreleaser softprops/action-gh-release step entirely and lets goreleaser own the full lifecycle: create draft, upload assets, publish. Also renames the job from create_release to release_metadata (it only computes tag/version metadata now) and tightens workflow-level permissions from contents:write to contents:read. Change-Type: fix Release-Note: no Audience: operator Impact: medium Breaking: false Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
needs triage
tashian
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
softprops/action-gh-releasepre-creation step that was causing goreleaser to leave permanent draft releases on GitHubcreate_releasejob torelease_metadatato reflect that it only computes tag/version metadatacontents: writetocontents: readRoot cause
The workflow was creating a GitHub draft release before goreleaser ran. goreleaser preserves the draft state of releases it didn't create itself — it only un-drafts releases it creates. So every release was left as a permanent draft.
Fix
Lets goreleaser own the full release lifecycle: create draft → upload assets → publish. goreleaser was already configured for this (
draft: falsein.goreleaser.yml); the pre-creation step was always redundant.Test plan
gh release list --repo smallstep/cli🤖 Generated with Claude Code