fix: fix the Go module path#4130
Conversation
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
8663825 to
49bd23b
Compare
|
Thanks for filing this. My apologies. When I release v2.0.0 last year I was still very new to Go's package ecosystem. To fix this, I think we'll need to release a new tag, as well. And probably a new version of slsa-verifier. Can you tell us about your your use case for using that internal executable directly? It could take to go through the release process, but in the meantime, I think using the git commit digest could be okay. Let me know. |
I think so too.
I don't use slsa-builder-go directly. I'm not sure who installs slsa-builder-go by aqua and how he/she uses it. |
What do you think would need to be changed besides the import paths? I think it would require changes to folks importing the package downstream (including slsa-verifier) but would it need a new release? BTW, there are a few other projects that import the packages directly. We should probably consider stopping support for importing them at some point since I can imagine a future where many packages aren't needed anymore and go away (note that |
Summary
This pull request replaces
"github.com/slsa-framework/slsa-github-generatorwith"github.com/slsa-framework/slsa-github-generator/v2.The latest version of slsa-github-generator is https://github.com/slsa-framework/slsa-github-generator/releases/tag/v2.1.0 , so we should update the Go module path to
github.com/slsa-framework/slsa-github-generator/v2.Otherwise, packages are unavailable.
v1.10.0 is available.
$ go install github.com/slsa-framework/slsa-github-generator/internal/builders/go@v1.10.0But v2.1.0 is unavailable.
Testing Process
...
Checklist