feat: Record vars in BYOB workflows#3636
Draft
ianlewis wants to merge 7 commits intoslsa-framework:mainfrom
Draft
feat: Record vars in BYOB workflows#3636ianlewis wants to merge 7 commits intoslsa-framework:mainfrom
ianlewis wants to merge 7 commits intoslsa-framework:mainfrom
Conversation
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
15 tasks
Member
Author
Though, I think BYOB itself should support setting the vars we perhaps shouldn't set them for these builders since they don't need to be used in the TRW. |
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Member
Author
|
I'm kind of thinking we don't really care about this with BYOB for now since for builders the caller can just require users to pass vars as TRW inputs. We will need this to support generators but we don't currently support generators anyway so it isn't urgent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
varscontext is converted to JSON and passed tosetup-genericby the TRW in the same way that theinputscontext is added. Vars are then recorded in the SLSA token. Individualvarscan be masked from the provenance as well via theslsa-masked-varsfield in the same way as inputs.verify-tokenreads the vars from the SLSA token and includes them in the final provenance.Note that changes to the TRW are necessary to record the vars context.
TODO:
Updates #1555
Testing Process
Checklist