Skip to content

Updating http-router version due to compile error#12

Open
diogobeda wants to merge 5 commits into
slogsdon:masterfrom
diogobeda:update-http-router
Open

Updating http-router version due to compile error#12
diogobeda wants to merge 5 commits into
slogsdon:masterfrom
diogobeda:update-http-router

Conversation

@diogobeda

Copy link
Copy Markdown

I was trying to use placid for the first time based on the kitchen-sink example, but I stumbled on an error when running mix compile:

Compiled lib/handlers/v1/main.ex

== Compilation error on file lib/router.ex ==
** (CompileError) lib/router.ex:1: function send_resp/3 undefined
    (stdlib) lists.erl:1336: :lists.foreach/2
    (stdlib) erl_eval.erl:657: :erl_eval.do_apply/6

My router:

defmodule Kiwi.Router do
  use Placid.Router
  alias Kiwi.Handlers.V1

  version "v1" do
    get "/", V1.Main, :index
  end
end

After some investigation I found that the latest placid version uses the http-router#0.0.3, that calls that undefined send_resp/3. Than when I updated to http-router#0.0.4 and ran my project it compiled just fine.

@diogobeda

Copy link
Copy Markdown
Author

@slogsdon I tried to run tests with placid and http-router#0.0.3 but it passed ok. I'm an Elixir beginner so I couldn't understand pretty much why they did. Could you try to explain it to me, please?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.74% when pulling b917c34 on diogobeda:update-http-router into c6fcfed on slogsdon:master.

@slogsdon

Copy link
Copy Markdown
Owner

@diogobeda I'll merge this in once I figure out why a couple of the builds are failing. Have you seen anything like this with your local copy?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.74% when pulling 46d0fa9 on diogobeda:update-http-router into c6fcfed on slogsdon:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.74% when pulling 46d0fa9 on diogobeda:update-http-router into c6fcfed on slogsdon:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.74% when pulling 46d0fa9 on diogobeda:update-http-router into c6fcfed on slogsdon:master.

@slogsdon

slogsdon commented Apr 7, 2015

Copy link
Copy Markdown
Owner

@diogobeda I'm starting to think that 1.0.0-rc1 is not supported by the newest version of Hex. Would you mind removing 1.0.0-rc1 from the build matrix in .travis.yml and squashing your commits? I'll merge this in once everything it good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants