Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80.
Column documentation and generic tests using SQL double-quoted names in the manifest
now match the unquoted names in the catalog. For example,
"Top Performer"matchesTop Performer; doubled embedded quotes are decoded. Manifest columns and testreferences use the same normalization, retaining the existing case-insensitive
matching and leaving unquoted interior quotes intact.
Adds artifact-loading regressions for sources, models, seeds and snapshots, including
all three supported test-column reference locations, escaped quotes, ordinary mixed
case names and one-sided quote characters. README documents the matching semantics.
Validation:
cases. After the change: 88 passed.
quoted documentation, quoted tests, escaped-quote tests and ordinary mixed-case
tests; all four output JSON reports had one hit and one covered column.
pre-commit run --all-filespassed all applicable hooks, including pinned isort and Black.Limitations: JSON artifacts are synthetic representations of the reported artifact
shapes, not newly generated by a warehouse/dbt run. This change retains the existing
lowercase behavior; it does not add warehouse-specific case-sensitive matching or
other SQL quoting styles. The entire dbt 1.1–1.12 integration matrix is not claimed
as passing. Open PR #64 addresses missing table paths/generic test nodes and does not
overlap these normalization hunks. Issue #80 was open, unassigned, and had no claim
comments when checked; no external claim or PR was posted.
AI disclosure: implementation and tests were prepared with OpenAI Codex. The actual
GitHub Copilot CLI independently inspected the final source, regression and README
files in read-only mode and reported no actionable defects (session
551ac1f0-593c-4eae-ada5-ac3fe2a039a9). Copilot did not run tests or validate againsta warehouse. Review is advisory and does not represent maintainer approval.