Add iOS typing perf automation and profiling workflows#418
Draft
futurepaul wants to merge 1 commit intosledtools:masterfrom
Draft
Add iOS typing perf automation and profiling workflows#418futurepaul wants to merge 1 commit intosledtools:masterfrom
futurepaul wants to merge 1 commit intosledtools:masterfrom
Conversation
# Conflicts: # ios/Sources/Views/ChatView.swift
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an iOS typing-performance workflow focused on composer keypress responsiveness and UI-thread work during typing.
It introduces:
TypingPerfUITests.justone-liners for summary, trace capture, keypress stack analysis, and samply profiling.ChatViewto correlate text changes with sampled work.nixshell additions forinfernoandsamply.docs/perf-testing.md.New commands
just ios-typing-perfavg,best,worst,samples, plus bulk baseline when available).just ios-typing-perf-tracejust ios-typing-perf-keypress-profilejust ios-typing-perf-keypress-profile-symbolizedjust ios-typing-perf-samplysamplycopy.xctraceflow by default when samply hits known attach instability.Why fallback exists
On macOS simulator attach,
samplycan intermittently panic with:Could not check process librariesInvalidAddressTo keep the one-liner reliable for day-to-day perf diagnosis, the script falls back to
ios-typing-perf-keypress-profile-symbolizedunless explicitly disabled.Scope / current limitations
Validation done
bash -nsanity checks for all added/updated shell tooling.ios-typing-perfios-typing-perf-keypress-profile-symbolizedios-typing-perf-samply(including fallback behavior)