✨ exclude deleted bookmarks from search results - #115
Merged
Merged
Conversation
- Add validBookmarkIds filter to getUserBookmarkItem - Filter deleted bookmarks in getBookmarkVectorShard and getUserBookmarkIds - Ensure search results only include active bookmarks (deleted_at IS NULL)
- Add clearSearchCache to SearchService, clears all 3 search KV cache keys - Call it synchronously after create, delete, trash, and restore bookmark
2 tasks
Whyjsee
changed the title
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
…ed-bookmarks-from-search-v2 # Conflicts: # src/infra/repository/dbBookmark.ts Co-authored-by: Whyjsee <7569533+Whyjsee@users.noreply.github.com>
Contributor
Whyjsee
changed the title
DGuang21
approved these changes
Sep 9, 2026
DGuang21
deleted the
feature/exclude-deleted-bookmarks-from-search-v2
branch
September 9, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleted_at IS NOT NULL) from search candidatesvalidBookmarkIdscheck ingetUserBookmarkItemto filter both vector shard and fulltext row datadeleted_at IS NULLfilter togetBookmarkVectorShardandgetUserBookmarkIdsclearSearchCachetoSearchService, called synchronously after bookmark create/delete/trash/restoreTest plan