Replace deprecated lodash.isequal with internal implementation to remove warnings#111
Open
r-farkhutdinov wants to merge 1 commit intoslab:mainfrom
Open
Replace deprecated lodash.isequal with internal implementation to remove warnings#111r-farkhutdinov wants to merge 1 commit intoslab:mainfrom
r-farkhutdinov wants to merge 1 commit intoslab:mainfrom
Conversation
|
I hope this PR will merge |
|
@r-farkhutdinov why not use lodash directly and let tree-shaking remove what is not needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes the deprecated
lodash.isequaldependency, which is currently used by this package and causes deprecation warnings for downstream consumers.Since
lodash.isequal@4.5.0is no longer maintained and emits security/audit warnings, we’ve replaced it with a minimal internal utility that performs deep equality checks for arrays and plain objects.What was done
lodash.isequalfrom dependenciesisEqualutility that handles the required comparison logicBenefits
Let me know if you'd prefer to replace it with a different utility (e.g.
fast-deep-equal) instead of a custom implementation.