Skip to content

ci(pr-fast): run heavy jobs only in the merge queue, not on every PR #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubrobbi merged 1 commit into from
Jun 26, 2026
Merged

ci(pr-fast): run heavy jobs only in the merge queue, not on every PR #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions .github/workflows/pr-fast.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,25 @@ jobs:
# sanity — `cargo check` + `cargo-vet`. The fastest compile gate;
# downstream heavy jobs `needs: sanity` so a type error aborts before
# paying for clippy / tests / Windows.
#
# Heavy jobs (sanity / clippy{,-no-default} / docs / test-build / tests /
# security / windows-lint) carry `&& github.event_name != 'pull_request'`
# so they run ONLY on `merge_group` (the merge queue) and `push` (main),
# not on the PR itself. Rationale: the merge queue revalidates every PR
# against current `main` before merging, so a `pull_request` run is a
# redundant second pass — the contributor's local `lint-pre-push` gate
# already ran the same full suite before the push. Running heavy CI once,
# in the queue, halves Rust-PR CI without losing safety. The `required`
# aggregator below treats these jobs' `skipped` (on PRs) as a pass, so a
# PR still goes green and can enter the queue; on `merge_group` they run
# for real and gate the merge. Cheap checks (fmt / file-size / drift /
# classify) stay on `pull_request` for fast author feedback.
# ─────────────────────────────────────────────────────────────────────
sanity:
name: Sanity (cargo check + vet)
runs-on: ubuntu-22.04
needs: classify
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 20
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down Expand Up @@ -383,7 +396,7 @@ jobs:
name: Clippy
runs-on: ubuntu-22.04
needs: [classify, sanity]
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 30
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down Expand Up @@ -415,7 +428,7 @@ jobs:
name: Clippy (--no-default-features)
runs-on: ubuntu-22.04
needs: [classify, sanity]
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 30
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down Expand Up @@ -445,7 +458,7 @@ jobs:
name: Rustdoc + doctests
runs-on: ubuntu-22.04
needs: [classify, sanity]
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 30
env:
RUSTDOCFLAGS: "-Dwarnings"
Expand Down Expand Up @@ -478,7 +491,7 @@ jobs:
name: Test build
runs-on: ubuntu-22.04
needs: [classify, sanity]
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 30
env:
# `debuginfo=1` for useful backtraces without paying the full
Expand Down Expand Up @@ -517,7 +530,7 @@ jobs:
name: Tests
runs-on: ubuntu-22.04
needs: [classify, test-build]
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 30
env:
# Must match test-build exactly so the cargo fingerprint lines up
Expand Down Expand Up @@ -561,7 +574,7 @@ jobs:
name: Security (deny + vet)
runs-on: ubuntu-22.04
needs: classify
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 20
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down Expand Up @@ -643,7 +656,7 @@ jobs:
name: Windows clippy
runs-on: windows-latest
needs: [classify, sanity]
if: needs.classify.outputs.code == 'true'
if: needs.classify.outputs.code == 'true' && github.event_name != 'pull_request'
timeout-minutes: 25
env:
# Windows-appropriate target-cpu baseline (same as release.yml's
Expand Down
Loading