Skip to content

fix(self-update): remove '--' from manifest XML comment — the real SxS 14001 cause #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubrobbi merged 1 commit into from
Jun 18, 2026
Merged

fix(self-update): remove '--' from manifest XML comment — the real SxS 14001 cause #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/uffs-update/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@
heuristic from force-elevating this binary purely because its NAME contains
"update" — without it, `uffs.exe` (non-elevated) cannot spawn
`uffs-update.exe`; it fails with ERROR_ELEVATION_REQUIRED (os error 740),
breaking every `uffs --update` operation. The self-update helper only
rewrites files in the user's own install dir; it never needs Administrator.
breaking every `uffs` self-update operation. The helper only rewrites
files in the user's own install dir; it never needs Administrator.

DO NOT write a double hyphen anywhere inside this comment block. XML
forbids "- -" (no space) in a comment body, and Windows' side-by-side
manifest parser rejects the whole manifest as "Invalid Xml syntax" if it
finds one — which is exactly the os error 14001 crash this file once had
(the old comment contained the literal CLI flag with two leading dashes).

WHY MINIMAL — nothing but `trustInfo`: an earlier, richer version of this
manifest (with `<assemblyIdentity>`, a `<compatibility>` supportedOS block,
Expand Down
Loading