SK-2680: Add JSON object context support for Conditional Data Access#177
Open
samsternberg wants to merge 1 commit intomainfrom
Open
SK-2680: Add JSON object context support for Conditional Data Access#177samsternberg wants to merge 1 commit intomainfrom
samsternberg wants to merge 1 commit intomainfrom
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
GoSec Findings: No issues found, Good to merge. |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
samsternberg
changed the title
Widen Ctx field on BearerTokenOptions, SignedDataTokensOptions, and
Credentials.Context from string to interface{} so the JWT ctx claim
can be a map[string]interface{} (nested JSON object). This enables
Conditional Data Access CEL expressions like
request.context.role == 'admin'.
Add ValidateAndResolveCtx() helper with key validation regex for CEL
compatibility. Add error constants for invalid ctx type and keys.
Update README and samples with string and map context examples.
Refs SK-2679
Co-Authored-By: Claude <noreply@anthropic.com>
samsternberg
force-pushed
the
feature/SK-2679-conditional-data-access-ctx-map-support
branch
from
bafc7ff to
ae66d8a
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
GoSec Findings: No issues found, Good to merge. |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CtxonBearerTokenOptions,SignedDataTokensOptions, andCredentials.Contextfromstringtointerface{}to supportmap[string]interface{}ValidateAndResolveCtx()helper with key validation (alphanumeric + underscores only) for CEL compatibilityINVALID_CTX_TYPE,INVALID_CTX_MAP_KEY,EMPTY_CONTEXTReplaces #176 (which was created from a fork and couldn't run CI).
Test plan
go build ./...— cleango vet ./...— cleango test ./...— identical pass/fail counts vs main (no regressions)Refs SK-2680, DOCU-1439