chore(sdlc): migrate quality_checks to the verbs map - #177
Merged
Merged
Conversation
`quality_checks:` is not a key in SdlcConfigSchema, and the schema is declared `additionalProperties: false`. `loadConfig` never throws — a schema-invalid document degrades to the all-defaults object — so the unknown key was not merely ignored, it voided the whole file. That took `lease_authority: origin` down with it. Moves the gate to `verbs.check` where consumers actually look for it (`sdlc quality run`, task-work Step 7, both via the `resolveVerb` cascade), and pins `setup-hooks: []`. The empty list is load-bearing: absent falls back to `setup`, whose built-in default resolves to the wrong recipe in this workspace. Restores a migration that was lost to a `git reset --hard` during the 0.7.1 release work.
Deploying ontogen with
|
| Latest commit: |
61ea70e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2444fd9a.ontogen.pages.dev |
| Branch Preview URL: | https://chore-sdlc-yaml-verbs.ontogen.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores a migration that was lost to a
git reset --hardduring the 0.7.1 release work.The part that is worse than a stale key
quality_checks:is not a key inSdlcConfigSchema, and the schema is declaredadditionalProperties: false.loadConfignever throws — on a schema-invalid document it degrades to the all-defaults object, same as an empty file.So the unknown key was not being ignored in isolation. It invalidated the whole document, which took
lease_authority: origindown with it. The file has been inert, not merely out of date.Changes
quality_checks:→verbs.check:, where consumers actually look (sdlc quality run, task-work Step 7, both through theresolveVerbcascade). Value is unchanged:just full-check.setup-hooks: []added. The empty list is load-bearing — per the schema's own description, absent falls back tosetup, whose built-in default resolves to the wrong recipe in this workspace (the iron-log example'sjust setup). An explicit[]means nothing runs.SdlcConfigSchemaas the authoritative shape, and at/sdlc:find-verbsrather than the renamed/sdlc:find-quality-checks.lease_authority: originis unchanged and should now actually take effect.Verification
Config-only; no code paths touched.
just full-checkis unchanged as the gate and CI runs it on this PR.