fix(changelog): match the crate-prefixed tags release-plz creates - #175
Merged
Merged
Conversation
`tag_pattern = "v[0-9].*"` matched none of this workspace's release tags.
release-plz prefixes them with the crate name — `ontogen-v0.7.0`,
`ontogen-core-v0.5.0` — so the pattern only ever matched the four legacy
tags from before the workspace split, `v0.1.0` through `v0.3.0`.
git-cliff could then find no current release to bound the range against
and emitted an almost-empty changelog. The 0.7.1 release PR lists one
commit; fourteen are in range. Same config, same repo, two boundaries:
git-cliff … ontogen-v0.7.0..main 4 Added, 1 Changed, 9 Fixed
git-cliff … --unreleased 1 Changed
Unset, every tag counts and the newest bounds the range correctly;
release-plz passes the per-package range explicitly regardless.
Also skip `^merge`. A `merge: …` subject parses as a conventional commit,
so the stack-merge commits were forming their own `### merge` section in
the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
0.7.1section of the release PR is empty despite fourteen commits being in range. This is why.Cause
cliff.tomlpinnedtag_pattern = "v[0-9].*", but release-plz prefixes release tags with the crate name in a workspace:That pattern matches none of them — only the four legacy tags from before the workspace split (
v0.1.0,v0.2.1,v0.2.2,v0.3.0). With no current release tag to bound the range, git-cliff has nothing to diff against and emits almost nothing.Same config, same repo, two boundary strategies:
ontogen-v0.7.0..main--unreleased(viatag_pattern)The commits and
commit_parserswere never the problem.Fix
Unset
tag_pattern. Every tag then counts, so the newest one bounds the range correctly, and release-plz passes the per-package range explicitly regardless.Also skips
^merge: amerge: …subject parses as a conventional commit, so the stack-merge commits from resolving the PR stack were forming their own### mergesection in the release notes.Verified
git-cliff --config cliff.toml --unreleasednow renders all fourteen commits under Added / Changed / Fixed, with nomergesection.just full-checkgreen.Merging this re-triggers release-plz, which should regenerate #174 with real release notes.