Update max sandbox time to 20 minutes - #68
Open
ai-yappa[bot] wants to merge 1 commit into
Open
ai-yappa[bot] wants to merge 1 commit into
ai-yappa[bot] wants to merge 1 commit into
Conversation
Change DEFAULT_CONFIG.max_time from 30m to 20m so new sessions created via the CLI, web, or Slack default to a 20-minute sandbox lifetime. Add a shared config test locking the default in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the default max sandbox time to 20 minutes by changing
DEFAULT_CONFIG.max_timefrom"30m"to"20m"inpackages/shared/src/config.ts.Why
The default
max_timeis the maximum lifetime of a sandbox/coding session. Sessions created without an explicit--max-time/max_session_time— including those started from the CLI, web UI, and Slack (@codevilmentions) — inherit this value via the session-directory and orchestrator defaults. Updating the default means new sessions get a 20-minute sandbox lifetime.Changes
packages/shared/src/config.ts:max_time: "30m"→"20m".packages/shared/test/config.test.mjs(new): locks in the 20-minute default and the other default config values.Verification
pnpm --filter @codevil/shared test: 226 pass (2 new)pnpm --filter @codevil/worker test: 491 passpnpm --filter @codevil/cli test: 28 passpnpm --filter @codevil/web test: 254 passpnpm --filter @codevil/shared typecheck: cleanExisting sessions keep their stored
max_session_time; only the default for new sessions changes.