chore: remove dead UI, unused deps, and duplicate code - #53
Merged
Merged
Conversation
Over-engineering cleanup pass (ponytail audit): - delete 23 unused React components (previous session UI replaced by Timeline/ActivityTab) and 6 unused shadcn primitives - delete 1.6MB prototype Codevil (standalone).html - strip ~1011 lines of dead CSS for the deleted components - drop unused deps: shiki, react-resizable-panels, lucide-react (dialog close X inlined as SVG), @tanstack/react-router-devtools - port the 16 unique event-mapper tests into shared projections.test.mjs and delete the duplicated web-side test file - drop unused ConfigSchema/ConfigDefaultsSchema (CLI hand-validates) and the runtime-unused DEFERRED_PROVIDER_IDS export (behavior stays tested) - consolidate ws-token onto capability-token (removes a hand-rolled HMAC/base64url implementation) pnpm verify: 903 tests, 0 failures. No behavior change intended.
Greptile SummaryThis PR removes obsolete UI code, styles, dependencies, duplicate tests, and unused shared exports while consolidating WebSocket authorization tokens onto the existing capability-token implementation.
Confidence Score: 5/5The PR appears safe to merge with no concrete changed-code defects identified. The retained code has no unresolved imports or live references to the deleted UI and dependencies, the moved tests preserve the unique projection cases, and the WebSocket token consolidation retains the required authentication checks.
|
| Filename | Overview |
|---|---|
| packages/worker/src/ws-token.ts | Replaces the bespoke WebSocket token format with audience-scoped capability tokens while retaining session, identity, role, signature, and expiry validation. |
| packages/shared/src/config.ts | Removes unused runtime schemas and parsed aliases while preserving the configuration interfaces and defaults. |
| packages/shared/src/providers.ts | Removes an unused deferred-provider constant and type without changing the supported-provider registry. |
| packages/shared/test/projections.test.mjs | Adds the unique event-projection coverage formerly located in the web package. |
| packages/web/src/components/ui/dialog.tsx | Replaces the removed lucide close icon with an equivalent inline SVG. |
| packages/web/src/session-components.css | Removes styles associated with deleted UI while retaining selectors referenced by the live session interface. |
| packages/web/package.json | Removes web dependencies for which no retained source imports remain. |
Reviews (1): Last reviewed commit: "chore: remove dead UI, unused deps, and ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Over-engineering cleanup pass. Deletion-only in spirit: zero behavior change, zero coverage lost.
Timeline/ActivityTab, plus 6 unused shadcn primitives (dropdown-menu, scroll-area, resizable, collapsible, badge, separator)Codevil (standalone).html(unreferenced)session-components.css— every class verified against live source before cutting (lookalikes liketimeline-msg-*,activity-turn-*,home-*kept)shiki,react-resizable-panels,lucide-react(dialog close X inlined as SVG),@tanstack/react-router-devtoolsweb/src/lib/__tests__/event-mapper.test.tsintoshared/test/projections.test.mjs(node:test), then deleted the duplicateConfigSchema/ConfigDefaultsSchema(CLI hand-validates;Configtype +DEFAULT_CONFIGkept) and the runtime-unusedDEFERRED_PROVIDER_IDSexport (deferred-provider rejection stays tested)ws-token.tsontocapability-token.ts— removes a second hand-rolled HMAC/base64url token implementation (worker-internal token format; tests are round-trip based)Verification
pnpm verifyon this branch: exit 0 — 903 tests, 0 failures across shared / cli / admin-cli / web / workerNet
37 files, +430 / −5,286. No new abstractions; the tree gets smaller.
Skipped deliberately (needs separate decisions): observability/wide-event layer, validation-drop sink,
legacyDirectoryGuardColumns(requires a D1 migration to dropNOT NULLcolumns), zod v3/v4 unification.