Repository navigation
Conversation
Downloading from /mnt/private now requires --include-private and a confirmation prompt (--force skips it). Syncing from a parent such as /mnt/ adds an anchored exclude for the private filesystem.
- Treat an empty or unreadable confirmation answer as no instead of panicking - Return nil when a private download is declined, matching other commands - Skip the confirmation prompt for --dry-run - Match globs per path element so globs that can't reach private files are allowed - Rename privateScopeInside to privateScopeRequiresFlag - Add tests for globs, local paths with colons, dry runs and declining
Merge the generateArgs tests into one table and group private file plan cases by outcome, checking each private source with and without the flag and dry run.
kimpepper
requested review from
nickschuch and
nterbogt
and removed request for
nickschuch
November 2, 2026 00:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/mnt/private(or paths that reach it via..,.or globs) fail unless--include-privateis set, then prompt for confirmation;--forceskips the prompt and--dry-rundoesn't promptdev:/mnt/ordev:/add an anchored exclude for the private filesystem and print a notice--include-privateand--forceflags, help text and table tests for path handling