Skip to content

feat(rsync): exclude private files from downloads by default - #113

Open
kimpepper wants to merge 4 commits into
mainfrom
feat/psec-22-rsync-private-files
Open

kimpepper wants to merge 4 commits into
mainfrom
feat/psec-22-rsync-private-files

Conversation

@kimpepper

@kimpepper kimpepper commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor
  • Downloads from /mnt/private (or paths that reach it via .., . or globs) fail unless --include-private is set, then prompt for confirmation; --force skips the prompt and --dry-run doesn't prompt
  • Downloads from a parent directory such as dev:/mnt/ or dev:/ add an anchored exclude for the private filesystem and print a notice
  • Uploads and relative remote paths are unchanged
  • Confirmation prompts treat an empty or unreadable answer as "no" instead of panicking (affects all commands that prompt)
  • Adds --include-private and --force flags, help text and table tests for path handling
  • Related server change: skpr/skpr#900

Downloading from /mnt/private now requires --include-private and a
confirmation prompt (--force skips it). Syncing from a parent such as
/mnt/ adds an anchored exclude for the private filesystem.
@kimpepper kimpepper changed the title feat(rsync): Exclude private files from downloads by default (PSEC-22) feat(rsync): exclude private files from downloads by default Nov 2, 2026
- Treat an empty or unreadable confirmation answer as no instead of panicking
- Return nil when a private download is declined, matching other commands
- Skip the confirmation prompt for --dry-run
- Match globs per path element so globs that can't reach private files are allowed
- Rename privateScopeInside to privateScopeRequiresFlag
- Add tests for globs, local paths with colons, dry runs and declining
Merge the generateArgs tests into one table and group private file plan
cases by outcome, checking each private source with and without the flag
and dry run.
@kimpepper
kimpepper requested review from nickschuch and nterbogt and removed request for nickschuch November 2, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant