ci: ignore gcov source lookup errors in main coverage job - #15
Merged
Conversation
The pr-checks diff-coverage job already passes --gcov-ignore-errors=source_not_found and no_working_dir_found to gcovr; the main-checks coverage job was missing them, so gcovr aborted on Catch2 .gcda files whose sources live outside the report paths. Main Checks has never passed because of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
coveragejob in Main Checks aborts ingcovrwithGCOV could not find source fileon Catch2.gcdafiles, so Main Checks has never passed. Thediff-coveragejob in PR Checks already handles this with--gcov-ignore-errors=source_not_found/no_working_dir_found; apply the same flags here.