feat: trigger ingot rebuild on infrastructure changes - #36
Merged
Conversation
Add scripts/**, schema/**, and platforms.toml to push trigger paths. When these files change, all existing build-type molds are rebuilt to ensure published ingots reflect the latest infrastructure. Changes to detect-build-targets: - Diff all files (not just molds/) to detect INFRA_CHANGED - INFRA_CHANGED: include all existing molds for rebuild - Mold-only changes: existing source-change detection (unchanged) - Both: deduplicated union of infra + mold targets - workflow_dispatch: unchanged (explicit mold_path) Design rationale: - scripts/ changes affect build/validation logic for all molds - schema/ changes affect mold interpretation - platforms.toml changes affect platform matrix - .github/workflows/ excluded (affects how builds run, not what is built)
Build-type filtering happens in Step 2 (source type classification), not during the infrastructure change mold collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand the push trigger to include infrastructure files (scripts/,
schema/, platforms.toml) and rebuild all build-type molds when these
change.
Motivation
Previously, only molds/** changes triggered ingot rebuilds. Scripts or
schema changes required manual workflow_dispatch to rebuild affected
molds, which is error-prone (forgetting to trigger).
Since scripts/ and schema/ changes affect all molds equally, they should
trigger automatic rebuilds — same as pr-validation.yml already does for
validation.
Changes
Push trigger paths
detect-build-targets logic (push event)
Test plan