feat: add per-mold platform support declaration - #33
Merged
Conversation
Add optional source.platforms.supported field to mold schema. When specified, only listed platforms are built. When omitted, all Tier 1 platforms are used (backward compatible). Changes: - schema: add platformSupport definition with validated platform IDs - GCC 15.2.0 mold.toml: set supported to linux-x86_64 + linux-aarch64 (upstream GCC does not support aarch64-apple-darwin natively) - ingot-cast.yml: filter build matrix by source.platforms.supported - ingot-cast.yml: use per-mold expected count in completeness check
- Completeness check now counts intersection of source.platforms.supported and Tier 1 platforms, preventing permanently unpushable molds when supported contains non-Tier-1 platform IDs - Add uniqueItems constraint to source.platforms.supported schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
source.platforms.supportedfield to mold schema, allowingmolds to declare which platforms they support. Unsupported platforms are
skipped in the build matrix and completeness check.
Motivation
GCC 15.2.0 does not support
aarch64-apple-darwinnatively (Homebrewapplies custom patches from iains/gcc-14-branch). The current pipeline
assumes all build-type molds support all Tier 1 platforms, causing
darwin builds to fail.
Changes
Schema (mold-v1.schema.json)
platformSupportdefinition:source.platforms.supported(optional)(linux|darwin)-(x86_64|aarch64)uniqueItems: true,minItems: 1GCC mold.toml
source.platforms.supported = ["linux-x86_64", "linux-aarch64"]ingot-cast.yml
source.platforms= all Tier 1Test plan
molds/gcc/15.2.0builds only linux-x86_64 and linux-aarch64