fix: install build prerequisites in all CI stages - #31
Merged
Conversation
Each CI stage (configure, make, package) runs in a separate container. Prerequisites like libgmp-dev are only needed at configure time for header detection, but shared libraries (.so) must be present during make (compilation) and package (smoke test). Extract install_prerequisites() function and call it in: - configure stage: Step 6 (existing) - make stage: after loading configure-tree artifact - package stage: after loading installed-tree artifact apt-get install is idempotent so repeated calls are safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix GCC build failure in make stage caused by missing build prerequisites
(libgmp-dev, libmpfr-dev, libmpc-dev, libisl-dev) in the container.
Problem
The 3-stage CI pipeline runs each stage in a separate docker container.
Prerequisites installed during configure are not available in the make or
package containers. GCC make fails within ~1 minute because headers/libraries
from libgmp-dev etc. are missing.
Solution
Extract
install_prerequisites()function and call it in all three stages:apt-get installis idempotent, adding ~10-30 seconds per stage.Test plan
molds/gcc/15.2.0