Use toString(16) for num2hex and addr2hex instead of own implementation#13
Open
circl-lastname wants to merge 2 commits intoskilldrick:masterfrom
Open
Use toString(16) for num2hex and addr2hex instead of own implementation#13circl-lastname wants to merge 2 commits intoskilldrick:masterfrom
circl-lastname wants to merge 2 commits intoskilldrick:masterfrom
Conversation
|
also u might want to use padStart(2, '0') instead of own implemntation |
Author
|
I didn't know about it yet when I wrote this 4 years ago. I probably won't fix that unless the maintainer has interest in merging this patch though, I wanna see how old it can get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two functions function the same way, but now they use toString(16), which is hopefully faster.