Changed CLI help display code, and added option to ignore names by regexp.#31
Open
adhihargo wants to merge 4 commits into
Open
Changed CLI help display code, and added option to ignore names by regexp.#31adhihargo wants to merge 4 commits into
adhihargo wants to merge 4 commits into
Conversation
skelterjohn
approved these changes
Sep 26, 2017
| // other files in the directory don't count - we watch the whole thing in case new .go files appear. | ||
| if filepath.Ext(we.Name) != ".go" { | ||
| if fn := filepath.Base(we.Name) ; | ||
| (ignoreRe != nil && ignoreRe.FindString(fn) != "") || filepath.Ext(fn) != ".go" { |
Owner
There was a problem hiding this comment.
please run gofmt - this line doesn't look like what gofmt would come up with.
|
If you add "Fixes #15" to the description/commit message GitHub automatically closes that issue when this is merge. |
…elterjohn#15 Some tools create temp files that rerun won't ignore if relying only on extension (e.g. on editing X.go emacs creates .#X.go).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi John,
Here's the modifications I made, in addition to Lachlan's: