Skip to content

Remove final from SaneOption#86

Open
phablotassio wants to merge 6 commits into
sjamesr:public_classesfrom
phablotassio:master
Open

Remove final from SaneOption#86
phablotassio wants to merge 6 commits into
sjamesr:public_classesfrom
phablotassio:master

Conversation

@phablotassio

Copy link
Copy Markdown

Since final classes can't be mocked with regular mockito it's more useful to not be final.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.036%

Totals Coverage Status
Change from base Build 272: 0.0%
Covered Lines: 923
Relevant Lines: 1139

💛 - Coveralls

1 similar comment
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.036%

Totals Coverage Status
Change from base Build 272: 0.0%
Covered Lines: 923
Relevant Lines: 1139

💛 - Coveralls

@sjamesr

sjamesr commented Jul 19, 2019

Copy link
Copy Markdown
Owner

I don't have a problem with this change, but I'm not sure why you'd want to mock SaneOptions, unless you're also mocking interactions with the SANE server. It's best to interact with a real sane server if at all possible, even if it's one built with just the test backend.

Also, do you mind rebasing your change onto the latest HEAD? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants