Prevent orphan actors from interrupted create requests#371
Open
level09 wants to merge 1 commit into
Open
Conversation
… clean up partial actors on failed create
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production incident: a DB stall during actor save left an actor row committed with no
actor_profileand no creation history. Text search inner-joins profiles, so the orphan was invisible to search while still reachable by ID; the user retried and produced a duplicate.Two changes:
Actor.from_jsonnow processesactor_profilesbefore events/medias/relations. Those blocks callsave()mid-flow, committing the half-built actor via session cascade; with profiles wired first, any such commit persists the actor together with its profiles, so a search-invisible actor can no longer be created.api_actor_createwraps the create flow and, on failure, deletes the partially committed actor before returning 500, so a client retry cannot leave duplicates behind.Test plan
TestActorCreateAtomicforces a failure after save and asserts no actor row survivesuv run pytest tests/test_core_entities.py tests/test_specialized.py(439 passed, 4 skipped)