Fix PSX raw sector EDC/ECC generation - #215
Merged
Merged
Conversation
Contributor
Author
|
Also do me a fave and add a credit for me :) Cheers |
This was referenced Aug 19, 2026
Owner
|
This needs to be fixed up as we don't do namespaces and the new file is not using Qt Object etc.. Ill get this looked over soon and updated so you guys can retest soon Edit: since this is a collection of inlines ill leave it as namespace for now.. Added a commit to bump Qt t. 6.9.3 should fix the mac os build issue. |
sithlord48
force-pushed
the
fix-psx-sector-edc-ecc
branch
from
August 21, 2026 22:42
6c7b7e8 to
96c2a91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes raw PSX CD-ROM sector integrity when
IsoArchivewrites or relocates sectors.The issue was found while investigating myst6re/makoureactor#51. In current ff7tk,
IsoArchiveIO::writeSector()constructs a 2352-byte sector with a zero-filled 280-byte footer,writeIso()can change the 2048-byte ISO payload without regenerating EDC/ECC, andcopySectors(..., repair=true)reconstructs moved sectors from only their 2048-byte payload.Changes:
writeSector();writeIso();writeIso();writeSector()remains limited to ff7tk's existing 24-byte Mode 2 XA header/subheader + 2048-byte payload layout. Existing Mode 1 sectors are handled by the relocation/repair helper rather than constructed throughwriteSector().The EDC/ECC algorithm is the same implementation already tested through Makou Reactor on an FF7 PSX image.
Related Makou Reactor PR: myst6re/makoureactor#233